<table><tr><td style="">dvratil requested changes to this revision.<br />dvratil added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28063">View Revision</a></tr></table><br /><div><div><p>Thanks a lot for the changes. I suggested some alternatives, you can use a tool called "Cuttlefish" to preview the icons, if you don't know it yet. It's better to focus on the <em>name</em> of the icon rather than what the icon looks like, because with other icon themes the icons may look differently and may not match the intention as much as Breeze does.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28063#inline-158883">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmmainwidget.cpp:3335</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">QAction</span> <span style="color: #aa2211">*</span><span class="n">action</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QAction</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Configure &Filters..."</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QAction</span> <span style="color: #aa2211">*</span><span class="n">action</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QAction</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QIcon</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromTheme</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"preferences-other"</span></span><span class="bright"></span><span class="p"><span class="bright">)),</span></span><span class="bright"> </span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Configure &Filters..."</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">action</span><span style="color: #aa2211">-></span><span class="n">setMenuRole</span><span class="p">(</span><span class="n">QAction</span><span style="color: #aa2211">::</span><span class="n">NoRole</span><span class="p">);</span>   <span style="color: #74777d">// do not move to application menu on OS X</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">How about <tt style="background: #ebebeb; font-size: 13px;">dialog-filters</tt>?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28063#inline-158881">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmmainwidget.cpp:3346</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">QAction</span> <span style="color: #aa2211">*</span><span class="n">action</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QAction</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"&Add Account..."</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QAction</span> <span style="color: #aa2211">*</span><span class="n">action</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QAction</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QIcon</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromTheme</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"contact-new-symbolic"</span></span><span class="bright"></span><span class="p"><span class="bright">)),</span></span><span class="bright"> </span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"&Add Account..."</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">actionCollection</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"accountWizard"</span><span class="p">),</span> <span class="n">action</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think <tt style="background: #ebebeb; font-size: 13px;">list-resource-add</tt> would be a better icon for this.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28063#inline-158882">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmmainwidget.cpp:3456</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">QAction</span> <span style="color: #aa2211">*</span><span class="n">action</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QAction</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Jump to Folder..."</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QAction</span> <span style="color: #aa2211">*</span><span class="n">action</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QAction</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QIcon</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromTheme</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"folder"</span></span><span class="bright"></span><span class="p"><span class="bright">)),</span></span><span class="bright"> </span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Jump to Folder..."</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">actionCollection</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"jump_to_folder"</span><span class="p">),</span> <span class="n">action</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Alternatively, <tt style="background: #ebebeb; font-size: 13px;">go-jump</tt> icon might be a good choice.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R206 KMail</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28063">https://phabricator.kde.org/D28063</a></div></div><br /><div><strong>To: </strong>sjolly, KDE PIM: KMail, dvratil<br /><strong>Cc: </strong>dvratil, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss<br /></div>