D29094: [KJotsEdit] Fix links handling in editing mode

Igor Poboiko noreply at phabricator.kde.org
Wed Apr 22 14:18:58 BST 2020


poboiko created this revision.
poboiko added a reviewer: dvratil.
Herald added a project: KDE PIM.
poboiko requested review of this revision.

REVISION SUMMARY
  When user Ctrl+Clicks on the link in the editing mode, emit the linkClicked signal
  (which is forwarded to corresponding slot inside `KJotsWidget`).
  
  We use `mousePressEvent` instead of `mouseReleaseEvent` to be able not to move the cursor
  when user ctrl+clicks on the link (so we override default `mousePressEvent`, which moves it)
  
  Add visual feedback when hovering the mouse over a link with ctrl pressed (override the cursor)

TEST PLAN
  Add Link, Ctrl+Click on it -> mouse cursor changes, link opens

REPOSITORY
  R573 KJots

BRANCH
  edit-links (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29094

AFFECTED FILES
  src/kjotsedit.cpp
  src/kjotsedit.h
  src/kjotswidget.cpp

To: poboiko, dvratil
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200422/70bd2d5e/attachment.html>


More information about the kde-pim mailing list