D28580: [Kleopatra] Fix size saving/restore

Andrey Legayev noreply at phabricator.kde.org
Sun Apr 19 18:05:59 BST 2020


andreylegayev updated this revision to Diff 80563.
andreylegayev added a comment.


  Updates: 
  I've got KDE developer access.
  Before committing anything I wanted to test it again and found that last version doesn't restore size on startup :-/
  It's fixed now and it's ready to be committed:
  
  - I've tested it on Kde Neon and Windows 10
  - Unit tests passed
  
  Changes:
  
  - removed `resize(1024, 500)` and `setAutoSaveSettings()` in MainWindow constructor
  - add `q->resize(QSize(1024, 500))` in MainWindow::Private::Private
  
  I've found that `setAutoSaveSettings()` is already added MainWindow::Private::Private()
  There is no need to add it in MainWindow constructor.
  
  @dfaure could you take a look at it last time?
  Should I push this commit directly to master?

REPOSITORY
  R168 Kleopatra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28580?vs=79830&id=80563

REVISION DETAIL
  https://phabricator.kde.org/D28580

AFFECTED FILES
  src/crypto/gui/decryptverifyfilesdialog.cpp
  src/crypto/gui/signencryptfileswizard.cpp
  src/crypto/gui/signencryptfileswizard.h
  src/kleopatraapplication.cpp
  src/mainwindow.cpp

To: andreylegayev, dfaure
Cc: dfaure, mlaurent, kde-pim, andreylegayev, fbampaloukas, dcaliste, dvasin, rodsevich, ach, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200419/b4117cfb/attachment.html>


More information about the kde-pim mailing list