D28580: [Kleopatra] Fix size saving/restore

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> andreylegayev wrote in mainwindow.cpp:706
> Replaced, but `setHidden()`

Oops, I missed a `!` in my suggested line of code, indeed. Or setHidden, which is equivalent indeed.

> andreylegayev wrote in mainwindow.cpp:696
> Thanks for the hint with setAutoSaveSettings(). I've added it to constructor.
> I've reverted back the rest to original version, but removed geometry save/load.
> 
> `readProperties` and `saveProperties` are really called only from session management. 
> I've re-checked it by setting breakpoints and by investigating source code:
> https://github.com/vasi/kdelibs/blob/master/kdeui/widgets/kmainwindow.cpp
> 
> Call chain from constructor - `readProperties()` isn't called:
> 
>   1. setAutoSaveSettings()
>   2. applyMainWindowSettings()
> 
> Call chain from session management:
> 
>   1. restore()
>   2. readPropertiesInternal()
>   3. applyMainWindowSettings() + readProperties()

I know. However I mistakenly thought kleopatra's code was calling readProperties() directly. It's not -- that's only in a readProperties() reimplementation, which I overlooked for lack of context in this patch (better use `arc`, but don't worry about that, we're moving to gitlab real soon now hopefully).

Sorry for the confusion.

REPOSITORY
  R168 Kleopatra

REVISION DETAIL
  https://phabricator.kde.org/D28580

To: andreylegayev, dfaure
Cc: dfaure, mlaurent, kde-pim, andreylegayev, fbampaloukas, dcaliste, dvasin, rodsevich, ach, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200411/10e86c10/attachment.html>