DAV calendar color (Was: [kdepim-runtime] resources/dav/resource: DAV resource: propagate color changes to the server)

[David Faure]

On Saturday, April 18, 2020 2:45:00 PM CEST Allen Winter wrote:
> On Saturday, April 18, 2020 8:15:52 AM EDT you wrote:
> > What I'm not sure about is what "Disable color" is supposed to do.
> > The code says "save an invalid color". OK... but what does it mean for the
> > user? Right now the calendar just gets some random color instead. What
> > purpose does this serve? Why not remove this action, which would remove a
> > submenu i.e. improve usability?
> Wild guess:
> remove your custom color assignment and revert to the color from the server
> side (if there is one)

Well the feature exists even for resources without a server, like "Personal 
Calendar".

Change color to yellow. Set "Disable color". Now it's green. That's not 
*disabled*, that's just another color.

And for DAV (and other resources that manage to save the color in the 
future?), there should be no difference between local and serverside anyway 
(and if you change it serverside or from another client, this has preference 
anyway).

> If we pushed our custom color to the server then we lost the server side
> info and there isn't much we can do. ... and of course we want to push our
> color so we have the same on all our clients. Agree that reverting to a
> random color doesn't make sense.
> 
> So I think David is correct.
>  * remove "Disable Color" submenu
>  * move "Assign Color" submenu up 1 level and rename as "Assign Calendar
> Color" (or somesuch)

Thanks, will do.

"Change Color" or "Set Color" would probably be clear enough?

This popup seems to call "Calendar" the whole resource (e.g. "Calendar 
Properties") and "Folder" the collection. So this is in fact "Assign Folder 
Color" or "Change Folder Color" if we want to be exact.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5