D28938: DAV resource: propagate color changes to the server

[Daniel Vrátil]

dvratil accepted this revision.
dvratil added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> dfaure wrote in davgroupwareresource.cpp:613
> That's *exactly* what I had initially. But as soon as this job does more than color -- like handling renamings -- then this approach doesn't work anymore.
> 
> The only issue is a job that changes nothing, this doesn't give any errors. And since we can't know here which attributes of the collection have changed, this will happen many times.
> 
> But see also my question about whether it actually makes sense to have an invalid color for a calendar, at all. From a user's point of view, I don't see it.

Yeah, I also do not understand the point of "Disable Color" if it just ends up assigning a random one...IMO it can be removed.

Regarding this code, guarding against invalid QColor still makes sense IMO to avoid breaking the DAV job in case there's something wrong stored in the configuration/Akonadi.

REPOSITORY
  R44 KDE PIM Runtime

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28938

To: dfaure, dvratil, ochurlaud, vkrause, winterz, mlaurent
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200418/1f01a150/attachment-0001.html>