D28937: EventViews::setResourceColor: modify the Akonadi::CollectionColorAttribute in the collection

[David Faure]

dfaure marked an inline comment as done.
dfaure added inline comments.

INLINE COMMENTS

> dvratil wrote in helper.cpp:63
> Bad indentation, missing context (e.g. `"Failed to set CollectionColorAttribute:" << job->errorString()`) - just randomly printing an error message into a log without context is almost as useful as not having it at all :)

Not for people who use %{function} in $QT_MESSAGE_PATTERN :-)

REPOSITORY
  R76 PIM: Event Views

REVISION DETAIL
  https://phabricator.kde.org/D28937

To: dfaure, dvratil, ochurlaud
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200418/002ed2f3/attachment.html>