D28937: EventViews::setResourceColor: modify the Akonadi::CollectionColorAttribute in the collection

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> helper.cpp:62
> +    QObject::connect(job, &Akonadi::CollectionModifyJob::result, [=]() {
> +        if (job->error())
> +        qCWarning(CALENDARVIEW_LOG) << job->errorString();

Missing parentheses

> helper.cpp:63
> +        if (job->error())
> +        qCWarning(CALENDARVIEW_LOG) << job->errorString();
> +    });

Bad indentation, missing context (e.g. `"Failed to set CollectionColorAttribute:" << job->errorString()`) - just randomly printing an error message into a log without context is almost as useful as not having it at all :)

REPOSITORY
  R76 PIM: Event Views

REVISION DETAIL
  https://phabricator.kde.org/D28937

To: dfaure, dvratil, ochurlaud
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200418/df0c8f18/attachment.html>