D7500: Event view can use the CollectionColorAttribute color

David Faure noreply at phabricator.kde.org
Sat Apr 18 10:18:09 BST 2020


dfaure added inline comments.

INLINE COMMENTS

> helper.cpp:51
> +            // It's the same color: we save an invalid color
> +            preferences->setResourceColor(id, QColor());
> +        }

For the record: this was broken, a `return;` was missing after this line, so we would anyway proceed to saving the color, 3 lines below.

But no matter, D28937 <https://phabricator.kde.org/D28937> removes all this logic. If we actually save into the attribute we don't need it anymore.

REPOSITORY
  R76 PIM: Event Views

REVISION DETAIL
  https://phabricator.kde.org/D7500

To: ochurlaud, dvratil, mlaurent
Cc: dfaure, mlaurent, dkurz, #kde_pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200418/c6cbf3a5/attachment.html>


More information about the kde-pim mailing list