D28585: Make implicitly shared types movable

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> davcollection.cpp:40
>  
>  DavCollection::DavCollection(const DavCollection &other) = default;
> +DavCollection::DavCollection(DavCollection &&) = default;

Just realizing now but if they're all set to `= default` anyway, why not rely on the rule of zero and simply drop them all?

> daverror.cpp:40
>  
>  Error::Error(const Error&) = default;
> +Error::Error(Error&&) = default;

Rule of zero candidate as well?

> daverror.h:47
>      Error(const Error&);
> +    Error(Error&&);
>      ~Error();

KF style is to put the space before the &

> daverror.h:50
>      Error& operator=(const Error&);
> +    Error& operator=(Error&&);
>  

same here

> davitem.cpp:36
>  
>  DavItem::DavItem(const DavItem &other) = default;
> +DavItem::DavItem(DavItem&&) = default;

Rule of zero candidate?

> davurl.cpp:34
>  
>  DavUrl::DavUrl(const DavUrl&) = default;
> +DavUrl::DavUrl(DavUrl &&) = default;

Rule of zero candidate?

> davurl.cpp:38
>  DavUrl& DavUrl::operator=(const DavUrl&) = default;
> +DavUrl& DavUrl::operator=(DavUrl &&) = default;
>  

Space before & in KF style

> davurl.h:39
>      DavUrl& operator=(const DavUrl&);
> +    DavUrl& operator=(DavUrl &&);
>  

Space before & in KF style

REPOSITORY
  R490 KDAV Library

REVISION DETAIL
  https://phabricator.kde.org/D28585

To: vkrause, ervin
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200405/9a455c2c/attachment.html>