<table><tr><td style="">ervin requested changes to this revision.<br />ervin added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28585">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28585#inline-162814">View Inline</a><span style="color: #4b4d51; font-weight: bold;">davcollection.cpp:40</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="n">DavCollection</span><span style="color: #aa2211">::</span><span class="n">DavCollection</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">DavCollection</span> <span style="color: #aa2211">&</span><span class="n">other</span><span class="p">)</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">default</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">DavCollection</span><span style="color: #aa2211">::</span><span class="n">DavCollection</span><span class="p">(</span><span class="n">DavCollection</span> <span style="color: #aa2211">&&</span><span class="p">)</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">default</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Just realizing now but if they're all set to <tt style="background: #ebebeb; font-size: 13px;">= default</tt> anyway, why not rely on the rule of zero and simply drop them all?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28585#inline-162817">View Inline</a><span style="color: #4b4d51; font-weight: bold;">daverror.cpp:40</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="n">Error</span><span style="color: #aa2211">::</span><span class="n">Error</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">Error</span><span style="color: #aa2211">&</span><span class="p">)</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">default</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">Error</span><span style="color: #aa2211">::</span><span class="n">Error</span><span class="p">(</span><span class="n">Error</span><span style="color: #aa2211">&&</span><span class="p">)</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">default</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Rule of zero candidate as well?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28585#inline-162815">View Inline</a><span style="color: #4b4d51; font-weight: bold;">daverror.h:47</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">Error</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">Error</span><span style="color: #aa2211">&</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">Error</span><span class="p">(</span><span class="n">Error</span><span style="color: #aa2211">&&</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa2211">~</span><span class="n">Error</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">KF style is to put the space before the &</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28585#inline-162816">View Inline</a><span style="color: #4b4d51; font-weight: bold;">daverror.h:50</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">Error</span><span style="color: #aa2211">&</span> <span class="n">operator</span><span style="color: #aa2211">=</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">Error</span><span style="color: #aa2211">&</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">Error</span><span style="color: #aa2211">&</span> <span class="n">operator</span><span style="color: #aa2211">=</span><span class="p">(</span><span class="n">Error</span><span style="color: #aa2211">&&</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28585#inline-162818">View Inline</a><span style="color: #4b4d51; font-weight: bold;">davitem.cpp:36</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="n">DavItem</span><span style="color: #aa2211">::</span><span class="n">DavItem</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">DavItem</span> <span style="color: #aa2211">&</span><span class="n">other</span><span class="p">)</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">default</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">DavItem</span><span style="color: #aa2211">::</span><span class="n">DavItem</span><span class="p">(</span><span class="n">DavItem</span><span style="color: #aa2211">&&</span><span class="p">)</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">default</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Rule of zero candidate?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28585#inline-162820">View Inline</a><span style="color: #4b4d51; font-weight: bold;">davurl.cpp:34</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="n">DavUrl</span><span style="color: #aa2211">::</span><span class="n">DavUrl</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">DavUrl</span><span style="color: #aa2211">&</span><span class="p">)</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">default</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">DavUrl</span><span style="color: #aa2211">::</span><span class="n">DavUrl</span><span class="p">(</span><span class="n">DavUrl</span> <span style="color: #aa2211">&&</span><span class="p">)</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">default</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Rule of zero candidate?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28585#inline-162821">View Inline</a><span style="color: #4b4d51; font-weight: bold;">davurl.cpp:38</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="n">DavUrl</span><span style="color: #aa2211">&</span> <span class="n">DavUrl</span><span style="color: #aa2211">::</span><span style="color: #aa4000">operator</span><span style="color: #aa2211">=</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">DavUrl</span><span style="color: #aa2211">&</span><span class="p">)</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">default</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">DavUrl</span><span style="color: #aa2211">&</span> <span class="n">DavUrl</span><span style="color: #aa2211">::</span><span style="color: #aa4000">operator</span><span style="color: #aa2211">=</span><span class="p">(</span><span class="n">DavUrl</span> <span style="color: #aa2211">&&</span><span class="p">)</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">default</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Space before & in KF style</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28585#inline-162822">View Inline</a><span style="color: #4b4d51; font-weight: bold;">davurl.h:39</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">DavUrl</span><span style="color: #aa2211">&</span> <span class="n">operator</span><span style="color: #aa2211">=</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">DavUrl</span><span style="color: #aa2211">&</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">DavUrl</span><span style="color: #aa2211">&</span> <span class="n">operator</span><span style="color: #aa2211">=</span><span class="p">(</span><span class="n">DavUrl</span> <span style="color: #aa2211">&&</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Space before & in KF style</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R490 KDAV Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28585">https://phabricator.kde.org/D28585</a></div></div><br /><div><strong>To: </strong>vkrause, ervin<br /><strong>Cc: </strong>kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>