D24085: Cleanup and modernize the Calendar library codebase

[Daniel Vrátil]

dvratil created this revision.
dvratil added a reviewer: barchiesi.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
dvratil requested review of this revision.

REVISION SUMMARY
  - enable C++14
  - use QScopedPointer for d-pointers
  - remove dead/unused code
  - refactor duplicated code into functions
  - use named constants instead of string literals to avoid typos but also to reduce the binary size due to string duplication
  - const'ify and auto'ify

TEST PLAN
  Compiles, tests pass

REPOSITORY
  R477 KGAPI Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24085

AFFECTED FILES
  CMakeLists.txt
  src/calendar/calendar.cpp
  src/calendar/calendar.h
  src/calendar/calendarcreatejob.cpp
  src/calendar/calendarcreatejob.h
  src/calendar/calendardeletejob.cpp
  src/calendar/calendardeletejob.h
  src/calendar/calendarfetchjob.cpp
  src/calendar/calendarfetchjob.h
  src/calendar/calendarmodifyjob.cpp
  src/calendar/calendarmodifyjob.h
  src/calendar/calendarservice.cpp
  src/calendar/calendarservice.h
  src/calendar/event.cpp
  src/calendar/event.h
  src/calendar/eventcreatejob.cpp
  src/calendar/eventcreatejob.h
  src/calendar/eventdeletejob.cpp
  src/calendar/eventdeletejob.h
  src/calendar/eventfetchjob.cpp
  src/calendar/eventfetchjob.h
  src/calendar/eventmodifyjob.cpp
  src/calendar/eventmodifyjob.h
  src/calendar/eventmovejob.cpp
  src/calendar/eventmovejob.h
  src/calendar/freebusyqueryjob.cpp
  src/calendar/freebusyqueryjob.h
  src/calendar/reminder.cpp
  src/calendar/reminder.h

To: dvratil, barchiesi
Cc: kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190919/325685eb/attachment.html>