<table><tr><td style="">dvratil created this revision.<br />dvratil added a reviewer: barchiesi.<br />Herald added a project: KDE PIM.<br />Herald added a subscriber: kde-pim.<br />dvratil requested review of this revision.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24085">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><ul class="remarkup-list">

<li class="remarkup-list-item">enable C++14</li>

<li class="remarkup-list-item">use QScopedPointer for d-pointers</li>

<li class="remarkup-list-item">remove dead/unused code</li>

<li class="remarkup-list-item">refactor duplicated code into functions</li>

<li class="remarkup-list-item">use named constants instead of string literals to avoid typos but also to reduce the binary size due to string duplication</li>

<li class="remarkup-list-item">const'ify and auto'ify</li>

</ul></div></div><br /><div><strong>TEST PLAN</strong><div><p>Compiles, tests pass</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R477 KGAPI Library</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24085">https://phabricator.kde.org/D24085</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />

src/calendar/calendar.cpp<br />

src/calendar/calendar.h<br />

src/calendar/calendarcreatejob.cpp<br />

src/calendar/calendarcreatejob.h<br />

src/calendar/calendardeletejob.cpp<br />

src/calendar/calendardeletejob.h<br />

src/calendar/calendarfetchjob.cpp<br />

src/calendar/calendarfetchjob.h<br />

src/calendar/calendarmodifyjob.cpp<br />

src/calendar/calendarmodifyjob.h<br />

src/calendar/calendarservice.cpp<br />

src/calendar/calendarservice.h<br />

src/calendar/event.cpp<br />

src/calendar/event.h<br />

src/calendar/eventcreatejob.cpp<br />

src/calendar/eventcreatejob.h<br />

src/calendar/eventdeletejob.cpp<br />

src/calendar/eventdeletejob.h<br />

src/calendar/eventfetchjob.cpp<br />

src/calendar/eventfetchjob.h<br />

src/calendar/eventmodifyjob.cpp<br />

src/calendar/eventmodifyjob.h<br />

src/calendar/eventmovejob.cpp<br />

src/calendar/eventmovejob.h<br />

src/calendar/freebusyqueryjob.cpp<br />

src/calendar/freebusyqueryjob.h<br />

src/calendar/reminder.cpp<br />

src/calendar/reminder.h</div></div></div><br /><div><strong>To: </strong>dvratil, barchiesi<br /><strong>Cc: </strong>kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>