D24035: Fix reported bug about replies to self

[Sandro Knauß]

knauss added inline comments.

INLINE COMMENTS

> replystrategytest.cpp:113
> +{
> +    QDir dir(QDir::homePath() + QDir::separator() +  QStringLiteral(".qttest"));
> +    dir.removeRecursively();

this only works on linux and please do not delete the complete `.qttest` dir, only the files that are problematic :

  QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation)+QDir::separator()  + QStringLiteral("emailidentities");

> replystrategytest.cpp:175
> +        << nobody << nobody << QString()
> +        << (int)ReplySmart << defaultAddress << only(friend1Address) << nobody;
> +    QTest::newRow("ReplySmart, from someone to non-default identity")

wait you have a original mail from `default -> friend2` and reply smart created a mail `default -> friend1`? Shouldn't it be :

  << (int)ReplySmart << defaultAddress << only(friend2Address) << nobody;

> replystrategytest.cpp:179
> +        << nobody << nobody << QString()
> +        << (int)ReplySmart << nondefaultAddress << only(friend1Address) << nobody;
> +    QTest::newRow("ReplySmart, from someone with Reply-To")

friend1Address vs. friend2Address

> replystrategytest.cpp:251
> +        << nobody << nobody << QString()
> +        << (int)ReplyAll << defaultAddress << only(friend1Address) << only(friend2Address);
> +    QTest::newRow("ReplyAll, with multiple To addresses in original")

friend1 vs friend2

> replystrategytest.cpp:255
> +        << nobody << nobody << QString()
> +        << (int)ReplyAll << nondefaultAddress << only(friend1Address) << only(friend2Address);
> +

friend1 vs friend2

> messagefactoryng.cpp:160
>              // doesn't seem to be a mailing list, reply to From: address
>              toList = m_origMsg->from()->mailboxes();
>  

rename the current `toList` into `fromList` and create the variable `toList=m_origMsg->to()->mailboxes()`

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D24035

To: gjditchfield
Cc: knauss, kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190917/19c9f547/attachment-0001.html>