<table><tr><td style="">knauss added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24035">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24035#inline-136022">View Inline</a><span style="color: #4b4d51; font-weight: bold;">replystrategytest.cpp:113</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QDir</span> <span class="n">dir</span><span class="p">(</span><span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">homePath</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">separator</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">".qttest"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">dir</span><span class="p">.</span><span class="n">removeRecursively</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this only works on linux and please do not delete the complete <tt style="background: #ebebeb; font-size: 13px;">.qttest</tt> dir, only the files that are problematic :</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation)+QDir::separator() + QStringLiteral("emailidentities");</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24035#inline-136025">View Inline</a><span style="color: #4b4d51; font-weight: bold;">replystrategytest.cpp:175</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="n">nobody</span> <span style="color: #aa2211"><<</span> <span class="n">nobody</span> <span style="color: #aa2211"><<</span> <span class="n">QString</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="p">(</span><span style="color: #aa4000">int</span><span class="p">)</span><span class="n">ReplySmart</span> <span style="color: #aa2211"><<</span> <span class="n">defaultAddress</span> <span style="color: #aa2211"><<</span> <span class="n">only</span><span class="p">(</span><span class="n">friend1Address</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span class="n">nobody</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QTest</span><span style="color: #aa2211">::</span><span class="n">newRow</span><span class="p">(</span><span style="color: #766510">"ReplySmart, from someone to non-default identity"</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">wait you have a original mail from <tt style="background: #ebebeb; font-size: 13px;">default -> friend2</tt> and reply smart created a mail <tt style="background: #ebebeb; font-size: 13px;">default -> friend1</tt>? Shouldn't it be :</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><< (int)ReplySmart << defaultAddress << only(friend2Address) << nobody;</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24035#inline-136026">View Inline</a><span style="color: #4b4d51; font-weight: bold;">replystrategytest.cpp:179</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="n">nobody</span> <span style="color: #aa2211"><<</span> <span class="n">nobody</span> <span style="color: #aa2211"><<</span> <span class="n">QString</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="p">(</span><span style="color: #aa4000">int</span><span class="p">)</span><span class="n">ReplySmart</span> <span style="color: #aa2211"><<</span> <span class="n">nondefaultAddress</span> <span style="color: #aa2211"><<</span> <span class="n">only</span><span class="p">(</span><span class="n">friend1Address</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span class="n">nobody</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QTest</span><span style="color: #aa2211">::</span><span class="n">newRow</span><span class="p">(</span><span style="color: #766510">"ReplySmart, from someone with Reply-To"</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">friend1Address vs. friend2Address</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24035#inline-136028">View Inline</a><span style="color: #4b4d51; font-weight: bold;">replystrategytest.cpp:251</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="n">nobody</span> <span style="color: #aa2211"><<</span> <span class="n">nobody</span> <span style="color: #aa2211"><<</span> <span class="n">QString</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="p">(</span><span style="color: #aa4000">int</span><span class="p">)</span><span class="n">ReplyAll</span> <span style="color: #aa2211"><<</span> <span class="n">defaultAddress</span> <span style="color: #aa2211"><<</span> <span class="n">only</span><span class="p">(</span><span class="n">friend1Address</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span class="n">only</span><span class="p">(</span><span class="n">friend2Address</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QTest</span><span style="color: #aa2211">::</span><span class="n">newRow</span><span class="p">(</span><span style="color: #766510">"ReplyAll, with multiple To addresses in original"</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">friend1 vs friend2</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24035#inline-136029">View Inline</a><span style="color: #4b4d51; font-weight: bold;">replystrategytest.cpp:255</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="n">nobody</span> <span style="color: #aa2211"><<</span> <span class="n">nobody</span> <span style="color: #aa2211"><<</span> <span class="n">QString</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="p">(</span><span style="color: #aa4000">int</span><span class="p">)</span><span class="n">ReplyAll</span> <span style="color: #aa2211"><<</span> <span class="n">nondefaultAddress</span> <span style="color: #aa2211"><<</span> <span class="n">only</span><span class="p">(</span><span class="n">friend1Address</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span class="n">only</span><span class="p">(</span><span class="n">friend2Address</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">friend1 vs friend2</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24035#inline-136031">View Inline</a><span style="color: #4b4d51; font-weight: bold;">messagefactoryng.cpp:160</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// doesn't seem to be a mailing list, reply to From: address</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">toList</span> <span style="color: #aa2211">=</span> <span class="n">m_origMsg</span><span style="color: #aa2211">-></span><span class="n">from</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">mailboxes</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">rename the current <tt style="background: #ebebeb; font-size: 13px;">toList</tt> into <tt style="background: #ebebeb; font-size: 13px;">fromList</tt> and create the variable <tt style="background: #ebebeb; font-size: 13px;">toList=m_origMsg->to()->mailboxes()</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R94 PIM: Message Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24035">https://phabricator.kde.org/D24035</a></div></div><br /><div><strong>To: </strong>gjditchfield<br /><strong>Cc: </strong>knauss, kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, dvratil<br /></div>