D23806: tests(mimetreeparser): Tests that are have no depdenency against MessageViewer should move to MimeTreeParser.

Roman Gilg noreply at phabricator.kde.org
Tue Sep 10 09:48:30 BST 2019


romangg added a comment.


  Thanks for trying out the unified git commit message guideline. :)
  
  Some small notes about the message header: The type should be just `test` without the `s`. The subject itself should be start in lower case without period in the end and in imperative, present tense. By that it can also be condensed in size and additional information put into the message:
  
    tests(mimetreeparser): move several tests to MimeTreeParser
    
    Tests that have no dependency against MessageViewer should be moved to
    MimeTreeParser. That's simply a move of tests to the right place.
  
  More information at https://github.com/angular/angular/blob/3cf2005a93/CONTRIBUTING.md#-commit-message-guidelines

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D23806

To: knauss, dvratil
Cc: romangg, kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190910/a3d328e9/attachment.html>


More information about the kde-pim mailing list