D24963: Prevent duplicates in url list.

Pierre Ducroquet noreply at phabricator.kde.org
Mon Oct 28 08:49:38 GMT 2019


pinaraf added a comment.


  Hum, sure it is an optimization on a non-optimizing compiler, but since QModelIndex::row() is const and declared in the headers, thus inlined when called, we don't really get anything here (on the contrary, on a -O3 code with GCC 9.2 on amd64 we get two extra instructions and allocate more stack because the variable is kept).
  Are you sure it is worth it?

REPOSITORY
  R201 Akregator

REVISION DETAIL
  https://phabricator.kde.org/D24963

To: pinaraf, mlaurent, #kde_pim
Cc: kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20191028/c7fa45c2/attachment.html>


More information about the kde-pim mailing list