D25399: korgac: honour notification inhibition by delaying reminders

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Nov 19 12:17:20 GMT 2019


broulik added a comment.


  lgtm

INLINE COMMENTS

> alarmdialog.cpp:792
> +            QDBusConnection::sessionBus());
> +    if (iface.inhibited()) {
> +        return;

This blocks.

What happens when the "inhibited" property doesn't exist? Will it return a default-constructed (`false`)?

REPOSITORY
  R210 KOrganizer

REVISION DETAIL
  https://phabricator.kde.org/D25399

To: dfaure, djarvie, broulik
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20191119/337bdc72/attachment.html>


More information about the kde-pim mailing list