D25399: korgac: honour notification inhibition by delaying reminders

David Faure noreply at phabricator.kde.org
Tue Nov 19 12:00:58 GMT 2019


dfaure created this revision.
dfaure added reviewers: djarvie, broulik.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
dfaure requested review of this revision.

REVISION SUMMARY
  Or in layman terms, don't pop up reminders during a presentation.
  
  Plasma has a "do not disturb" setting (which is even automatically
  enabled when mirroring the screen onto a projector), and that setting is
  available via a property in a freedesktop notifications interface.
  
  The code is in alarmdialog rather than alarmclient because the "suspend"
  code is in alarmdialog and calls wakeUp() directly.

TEST PLAN
  - Create event in korganizer with reminder in 2 minutes
  - Enable "do not disturb" mode in Plasma (Notifications systray icon)
  - Wait for > 2 minutes, no reminder
  - Disable "do not disturb" mode
  - The reminder shows immediately
  
  - Click Suspend for 1 minute
  - Enable "do not disturb" again
  - Wait for > 1 minute, no reminder
  - Disable "do not disturb" mode
  - The reminder shows immediately

REPOSITORY
  R210 KOrganizer

BRANCH
  release/19.12

REVISION DETAIL
  https://phabricator.kde.org/D25399

AFFECTED FILES
  korgac/CMakeLists.txt
  korgac/alarmdialog.cpp
  korgac/alarmdialog.h
  korgac/org.freedesktop.DBus.Properties.xml
  korgac/org.freedesktop.Notifications.xml
  korgac/tests/CMakeLists.txt

To: dfaure, djarvie, broulik
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20191119/bf5e3d1e/attachment.html>


More information about the kde-pim mailing list