D25289: Read floating date time as LocalTime.

[Damien Caliste]

dcaliste created this revision.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
dcaliste requested review of this revision.

REVISION SUMMARY
  Date time like DTSTART:20191113T120000 are considered like floating
  date time in RFC5545. This commit modifies the icalformat_p readICalDateTime
  functions not to use the system time zone in that case, but the
  LocalTime spec. Otherwise, there is no way to distinguish incoming
  floating time from time given in the system time zone. Then when
  exporting to iCal format, the floating format is not conserved.
  
  Also properly export date time in UTC using the Z character and not TZID=UTC
  as mentioned in RFC5545 section 3.3.5:
  "The "TZID" property parameter MUST NOT be applied to DATE-TIME
  
    properties whose time values are specified in UTC."

TEST PLAN
  A test is added in testicalformat.cpp to verify that floating date time,
  date, UTC date time and date time with a time zone are properly read
  and exported.

REPOSITORY
  R172 KCalendar Core

BRANCH
  rfc5545

REVISION DETAIL
  https://phabricator.kde.org/D25289

AFFECTED FILES
  autotests/testicalformat.cpp
  autotests/testicalformat.h
  src/icalformat_p.cpp
  src/icaltimezones.cpp

To: dcaliste
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20191113/c27e881c/attachment.html>