D20886: Add fields standard query parameter to Job and use it in FileFetchJob.

[Elvis Angelaccio]

elvisangelaccio added a comment.


  I think this patch needs to be rebased, here's what I get when I try to apply it:
  
    $ arc patch D20886
     INFO  Base commit is not in local repository; trying to fetch.
    Created and checked out branch arcpatch-D20886.
    Created and checked out branch arcpatch-D20789.
    Checking patch src/drive/permissionmodifyjob.h...
    Checking patch src/drive/permissionmodifyjob.cpp...
    Checking patch src/drive/permissionfetchjob.h...
    Checking patch src/drive/permissionfetchjob.cpp...
    Checking patch src/drive/permissiondeletejob.h...
    Checking patch src/drive/permissiondeletejob.cpp...
    Checking patch src/drive/permissioncreatejob.h...
    Checking patch src/drive/permissioncreatejob.cpp...
    Checking patch src/drive/parentreferencecreatejob.h...
    Checking patch src/drive/parentreferencecreatejob.cpp...
    Checking patch src/drive/filefetchjob.h...
    Checking patch src/drive/filefetchjob.cpp...
    Checking patch src/drive/fileabstractuploadjob.h...
    Checking patch src/drive/fileabstractuploadjob.cpp...
    Checking patch src/drive/childreferencecreatejob.h...
    Checking patch src/drive/childreferencecreatejob.cpp...
    Checking patch src/drive/changefetchjob.h...
    Checking patch src/drive/changefetchjob.cpp...
    Checking patch examples/teamdrive/ui/main.ui...
    Checking patch examples/teamdrive/mainwindow.h...
    Checking patch examples/teamdrive/mainwindow.cpp...
    Checking patch autotests/drive/data/file2_create_request.txt...
    error: the patch applies to 'autotests/drive/data/file2_create_request.txt' (b02b6ce294b8c3ad745edaa0b91eaeb4978c3da2), which does not match the current contents.
    error: autotests/drive/data/file2_create_request.txt: patch does not apply
    Checking patch autotests/drive/data/file1_create_request.txt...
    Checking patch autotests/drive/data/changes_fetch_page1_request.txt...
    Checking patch autotests/drive/data/change1_fetch_request.txt...
    Applied patch src/drive/permissionmodifyjob.h cleanly.
    Applied patch src/drive/permissionmodifyjob.cpp cleanly.
    Applied patch src/drive/permissionfetchjob.h cleanly.
    Applied patch src/drive/permissionfetchjob.cpp cleanly.
    Applied patch src/drive/permissiondeletejob.h cleanly.
    Applied patch src/drive/permissiondeletejob.cpp cleanly.
    Applied patch src/drive/permissioncreatejob.h cleanly.
    Applied patch src/drive/permissioncreatejob.cpp cleanly.
    Applied patch src/drive/parentreferencecreatejob.h cleanly.
    Applied patch src/drive/parentreferencecreatejob.cpp cleanly.
    Applied patch src/drive/filefetchjob.h cleanly.
    Applied patch src/drive/filefetchjob.cpp cleanly.
    Applied patch src/drive/fileabstractuploadjob.h cleanly.
    Applied patch src/drive/fileabstractuploadjob.cpp cleanly.
    Applied patch src/drive/childreferencecreatejob.h cleanly.
    Applied patch src/drive/childreferencecreatejob.cpp cleanly.
    Applied patch src/drive/changefetchjob.h cleanly.
    Applied patch src/drive/changefetchjob.cpp cleanly.
    Applied patch examples/teamdrive/ui/main.ui cleanly.
    Applied patch examples/teamdrive/mainwindow.h cleanly.
    Applied patch examples/teamdrive/mainwindow.cpp cleanly.
    Applied patch autotests/drive/data/file1_create_request.txt cleanly.
    Applied patch autotests/drive/data/changes_fetch_page1_request.txt cleanly.
    Applied patch autotests/drive/data/change1_fetch_request.txt cleanly.
    
     Patch Failed! 
    Usage Exception: Unable to apply patch!

REPOSITORY
  R477 KGAPI Library

REVISION DETAIL
  https://phabricator.kde.org/D20886

To: barchiesi, dvratil
Cc: elvisangelaccio, kde-pim, #libkgapi, barchiesi, gennad, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190519/625b63e3/attachment.html>