<table><tr><td style="">elvisangelaccio added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20886">View Revision</a></tr></table><br /><div><div><p>I think this patch needs to be rebased, here's what I get when I try to apply it:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="console" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">$ arc patch D20886</span>
<span style="color: #808080"> INFO  Base commit is not in local repository; trying to fetch.</span>
<span style="color: #808080">Created and checked out branch arcpatch-D20886.</span>
<span style="color: #808080">Created and checked out branch arcpatch-D20789.</span>
<span style="color: #808080">Checking patch src/drive/permissionmodifyjob.h...</span>
<span style="color: #808080">Checking patch src/drive/permissionmodifyjob.cpp...</span>
<span style="color: #808080">Checking patch src/drive/permissionfetchjob.h...</span>
<span style="color: #808080">Checking patch src/drive/permissionfetchjob.cpp...</span>
<span style="color: #808080">Checking patch src/drive/permissiondeletejob.h...</span>
<span style="color: #808080">Checking patch src/drive/permissiondeletejob.cpp...</span>
<span style="color: #808080">Checking patch src/drive/permissioncreatejob.h...</span>
<span style="color: #808080">Checking patch src/drive/permissioncreatejob.cpp...</span>
<span style="color: #808080">Checking patch src/drive/parentreferencecreatejob.h...</span>
<span style="color: #808080">Checking patch src/drive/parentreferencecreatejob.cpp...</span>
<span style="color: #808080">Checking patch src/drive/filefetchjob.h...</span>
<span style="color: #808080">Checking patch src/drive/filefetchjob.cpp...</span>
<span style="color: #808080">Checking patch src/drive/fileabstractuploadjob.h...</span>
<span style="color: #808080">Checking patch src/drive/fileabstractuploadjob.cpp...</span>
<span style="color: #808080">Checking patch src/drive/childreferencecreatejob.h...</span>
<span style="color: #808080">Checking patch src/drive/childreferencecreatejob.cpp...</span>
<span style="color: #808080">Checking patch src/drive/changefetchjob.h...</span>
<span style="color: #808080">Checking patch src/drive/changefetchjob.cpp...</span>
<span style="color: #808080">Checking patch examples/teamdrive/ui/main.ui...</span>
<span style="color: #808080">Checking patch examples/teamdrive/mainwindow.h...</span>
<span style="color: #808080">Checking patch examples/teamdrive/mainwindow.cpp...</span>
<span style="color: #808080">Checking patch autotests/drive/data/file2_create_request.txt...</span>
<span style="color: #808080">error: the patch applies to 'autotests/drive/data/file2_create_request.txt' (b02b6ce294b8c3ad745edaa0b91eaeb4978c3da2), which does not match the current contents.</span>
<span style="color: #808080">error: autotests/drive/data/file2_create_request.txt: patch does not apply</span>
<span style="color: #808080">Checking patch autotests/drive/data/file1_create_request.txt...</span>
<span style="color: #808080">Checking patch autotests/drive/data/changes_fetch_page1_request.txt...</span>
<span style="color: #808080">Checking patch autotests/drive/data/change1_fetch_request.txt...</span>
<span style="color: #808080">Applied patch src/drive/permissionmodifyjob.h cleanly.</span>
<span style="color: #808080">Applied patch src/drive/permissionmodifyjob.cpp cleanly.</span>
<span style="color: #808080">Applied patch src/drive/permissionfetchjob.h cleanly.</span>
<span style="color: #808080">Applied patch src/drive/permissionfetchjob.cpp cleanly.</span>
<span style="color: #808080">Applied patch src/drive/permissiondeletejob.h cleanly.</span>
<span style="color: #808080">Applied patch src/drive/permissiondeletejob.cpp cleanly.</span>
<span style="color: #808080">Applied patch src/drive/permissioncreatejob.h cleanly.</span>
<span style="color: #808080">Applied patch src/drive/permissioncreatejob.cpp cleanly.</span>
<span style="color: #808080">Applied patch src/drive/parentreferencecreatejob.h cleanly.</span>
<span style="color: #808080">Applied patch src/drive/parentreferencecreatejob.cpp cleanly.</span>
<span style="color: #808080">Applied patch src/drive/filefetchjob.h cleanly.</span>
<span style="color: #808080">Applied patch src/drive/filefetchjob.cpp cleanly.</span>
<span style="color: #808080">Applied patch src/drive/fileabstractuploadjob.h cleanly.</span>
<span style="color: #808080">Applied patch src/drive/fileabstractuploadjob.cpp cleanly.</span>
<span style="color: #808080">Applied patch src/drive/childreferencecreatejob.h cleanly.</span>
<span style="color: #808080">Applied patch src/drive/childreferencecreatejob.cpp cleanly.</span>
<span style="color: #808080">Applied patch src/drive/changefetchjob.h cleanly.</span>
<span style="color: #808080">Applied patch src/drive/changefetchjob.cpp cleanly.</span>
<span style="color: #808080">Applied patch examples/teamdrive/ui/main.ui cleanly.</span>
<span style="color: #808080">Applied patch examples/teamdrive/mainwindow.h cleanly.</span>
<span style="color: #808080">Applied patch examples/teamdrive/mainwindow.cpp cleanly.</span>
<span style="color: #808080">Applied patch autotests/drive/data/file1_create_request.txt cleanly.</span>
<span style="color: #808080">Applied patch autotests/drive/data/changes_fetch_page1_request.txt cleanly.</span>
<span style="color: #808080">Applied patch autotests/drive/data/change1_fetch_request.txt cleanly.</span>
<span style="color: #808080"></span>
<span style="color: #808080"> Patch Failed! </span>
<span style="color: #808080">Usage Exception: Unable to apply patch!</span></pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R477 KGAPI Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20886">https://phabricator.kde.org/D20886</a></div></div><br /><div><strong>To: </strong>barchiesi, dvratil<br /><strong>Cc: </strong>elvisangelaccio, kde-pim, LibKGAPI, barchiesi, gennad, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>