D19556: Factorize attribute handling into new AttributeStorage class.

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> attributestorage_p.h:61
> +    QHash<QByteArray, Attribute *> mAttributes;
> +    std::set<QByteArray> mModifiedAttributes;
> +    QSet<QByteArray> mDeletedAttributes;

What is the benefit of `std::set<T>` over a `QSet<T>` here? I don't mind using it, I'm just curious why you preferred it over `QSet`.

> tagfetchjob.cpp:155
> +    Tag tag = ProtocolHelper::parseTagFetchResult(resp);
> +    tag.d_ptr->resetChangeLog();
>      d->mResultTags.append(tag);

You already reset the changelog in `parseTagFetchResult()`, no need to do it here again.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D19556

To: dfaure, dvratil
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190306/a8561215/attachment.html>