D19556: Factorize attribute handling into new AttributeStorage class.

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> dvratil wrote in attributestorage_p.h:61
> What is the benefit of `std::set<T>` over a `QSet<T>` here? I don't mind using it, I'm just curious why you preferred it over `QSet`.

A hash table for just a few elements is overkill (memory-wise).

> dvratil wrote in tagfetchjob.cpp:155
> You already reset the changelog in `parseTagFetchResult()`, no need to do it here again.

Ah indeed -- I added that later.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D19556

To: dfaure, dvratil
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190306/a9fc8ea0/attachment.html>