D19739: Make the feed uri the baseUrl for previews

Pierre Ducroquet noreply at phabricator.kde.org
Thu Mar 14 20:33:16 GMT 2019


pinaraf marked an inline comment as done.
pinaraf added inline comments.

INLINE COMMENTS

> mlaurent wrote in articleviewerwidget.cpp:196
> Are you sure that article.feed()->xmlUrl() is never null ?

100% sure. See feed.cpp line 146 where Feeds are instanciated from OPML. Otherwise, they are instanciated when added by URL. Having it null would be terrible about everywhere in the codebase I think.

REPOSITORY
  R201 Akregator

REVISION DETAIL
  https://phabricator.kde.org/D19739

To: pinaraf, #kde_pim, mlaurent
Cc: mlaurent, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190314/288c311e/attachment.html>


More information about the kde-pim mailing list