D21444: Run grantleeheaderstyletest without kdepim-addons and without pre installat messagelib.

[Sandro Knauß]

knauss added a subscriber: ikloecker.
knauss added inline comments.

INLINE COMMENTS

> dfaure wrote in antispamconfig.cpp:65
> qputenv in the test and qgetenv here.
> Or make the test set an extern bool to true. See e.g. kio_resolve_local_urls in kio.
> 
> Or make the test closer to the regular case ;-)
> In fact I'm wondering why this says setReadDefaults(true), i.e. ignore user settings. That's usually for "Revert to defaults" buttons.

> qputenv in the test and qgetenv here.
>  Or make the test set an extern bool to true. See e.g. kio_resolve_local_urls in kio.

thx for the tips.

> Or make the test closer to the regular case ;-)

Well I want the tests to be working without installation and as non root I can't write to /usr/share. So I would need to control the default location and I don't see a way to achieve this.

> In fact I'm wondering why this says setReadDefaults(true), i.e. ignore user settings. That's usually for "Revert to defaults" buttons.

This I'm wondering, too. I tracked this line of code exists from the beginning of the git history and this file was added 2004 and that line was never touched since then. The commit message is:
"Add optional graphical spam status to fancy headers. Based on patch by Patrick Audley." commited by @ikloecker. But I expect Ingo also don't know why this line is needed.

I would suggest to remove this line as it seems to me, that it breaks stuff (e.g. our tests) and I can't imagine what we gain if we keep this line intact. With removing the line we gain the possibility for users to change the "kmail.antispamrc" for their needs.

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D21444

To: knauss, #kde_pim, dfaure
Cc: ikloecker, dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190624/ad34cd41/attachment.html>