D21544: [RFC] First draft of the new async client API to interact with Akonadi

Daniel Vrátil noreply at phabricator.kde.org
Sun Jun 2 15:18:52 BST 2019


dvratil added inline comments.

INLINE COMMENTS

> tagmodifyjob.cpp:54
>  
> +Tag TagModifyJob::tag() const
> +{

This method never got implemented, apparently, I'm the first one to use it :-)

> session.h:69
>  class AKONADICORE_EXPORT Session : public QObject
> +                                 , public QEnableSharedFromThis<Session>
>  {

The old API works with a raw pointer to `Session`, so to allow for the new API to use a `QSharedPointer`, ` QEnableSharedFromThis` is used to avoid breaking the existing API and code.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D21544

To: dvratil, kde-pim
Cc: dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190602/eca91322/attachment.html>


More information about the kde-pim mailing list