Apparmor profile for Akonadi MySQL backend

[Daniel Vrátil]

The files look fairly similar. I'd prefer to only have one version of the file 
in the Akonadi repo, of course - do you think it would be possible to unify 
them, so both Kubuntu and Neon would use the same file?

Feel free to create a review on Phab, we can discuss details there.

/Dan

On Saturday, 27 July 2019 23:23:01 CEST Sandro Knauß wrote:
> Hey,
> 
> yes is Debian [1], that is different than that on Neon, because Neon uses
> MySql  and Debian switched to MariaDB, that needs different settings. Keep
> also in mind, that those Apparmor profiles are about the underlying
> database and not the Akonadi executable in itself. Additionally Debian
> creates a symlink mysqld-akonadi -> mysqld  to apply an differnent Apparmor
> profile for Akonadi. Neon creates a small wrapper [2] to have a different
> executable.
> 
> sandro
> 
> [1] https://salsa.debian.org/qt-kde-team/kde/akonadi/blob/master/debian/
> usr.sbin.mysqld-akonadi
> 
> [2]
> https://packaging.neon.kde.org/kde/akonadi.git/tree/debian/mysqld-akonadi?
> h=Neon/release-lts
> 
> On Donnerstag, 18. Juli 2019 17:24:54 CEST Jonathan Riddell wrote:
> > On Fri, 12 Jul 2019 at 15:01, Daniel Vrátil <dvratil at kde.org> wrote:
> > > > This shouldn't be done in a bugfix release
> > > 
> > > Sorry about this, I had no idea this change would affect Apparmor. This
> > > was a
> > > bugfix for MacOS where the socket path was simply too long.
> > > 
> > > At the same time, you cannot assume all maintainers know about all such
> > > 3rd
> > > party software and know what changes might or might not affect it. 
> > > Maybe
> > > if
> > > the Apparmor config file for Akonadi was in the Akonadi repo and I knew
> > > about
> > > it, it would hit a bell in my head while doing the codereview for this
> > > change.
> > > But this way, even if I knew Apparmor would be affected by this change,
> > > I
> > > have
> > > no clue where to look for...whatever I have to look for in order to do
> > > or
> > > ask
> > > for the adjustments.
> > > 
> > > IMO since this is something you do in your packaging and is outside of
> > > upstream control, it's something you should check before pushing the
> > > package
> > > to your users, not blaming upstream for breaking your distro "patches".
> > 
> > Fair points, sorry I sounded blaming.
> > 
> > Any other distros out there use an apparmour profile?  Can we get it
> > upstream into akonadi directly?
> > 
> > https://packaging.neon.kde.org/kde/akonadi.git/tree/debian/usr.sbin.mysqld
> > -a konadi?h=Neon/release-lts
> > 
> > Jonathan


-- 
Daniel Vrátil
www.dvratil.cz | dvratil at kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)

GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190729/389aaa99/attachment-0001.sig>