D17954: Grantleetheme should always prefer files that are located in DataLocation.

[Sandro Knauß]

knauss added a comment.


  In D17954#386576 <https://phabricator.kde.org/D17954#386576>, @dfaure wrote:
  
  > The patch looks ok to me, but I'm not sure I understand the commit log, which talks about sorting. You don't need to sort, locateAll is sorted already (by order of the dirs in GenericDataLocation, which themselves have reliable order, e.g. it's the order of XDG_DATA_DIRS on linux)...
  
  
  from the patch itself it is not obvious, what is going wrong. I added a comment to the for loop (l127-l151) that is actually loading and overwriting the themes in a way you do not expect it in a Linux environment aka not able for the tests to set the themes (see D15727 <https://phabricator.kde.org/D15727>).

INLINE COMMENTS

> grantleethememanager.cpp:127
>  
>          for (const QString &directory : qAsConst(themesDirectories)) {
>              QDirIterator dirIt(directory, QStringList(), QDir::AllDirs | QDir::NoDotAndDotDot);

@dfaure you see this for loop l127 - l151, this will actually overwrites a found theme with a theme found in an other directory. So in the end the most general directory wins. IMO that is the opposite is expected, so that the general folders are fallback, if the local one is not found.

REPOSITORY
  R77 PIM: Grantlee Theme

REVISION DETAIL
  https://phabricator.kde.org/D17954

To: knauss, #kde_pim, mlaurent, dfaure
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190104/d64f67fb/attachment.html>