<table><tr><td style="">knauss added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17954">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D17954#386576" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D17954#386576</a>, <a href="https://phabricator.kde.org/p/dfaure/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dfaure</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>The patch looks ok to me, but I'm not sure I understand the commit log, which talks about sorting. You don't need to sort, locateAll is sorted already (by order of the dirs in GenericDataLocation, which themselves have reliable order, e.g. it's the order of XDG_DATA_DIRS on linux)...</p></div>
</blockquote>
<p>from the patch itself it is not obvious, what is going wrong. I added a comment to the for loop (l127-l151) that is actually loading and overwriting the themes in a way you do not expect it in a Linux environment aka not able for the tests to set the themes (see <a href="https://phabricator.kde.org/D15727" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D15727</a>).</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17954#inline-98954">View Inline</a><span style="color: #4b4d51; font-weight: bold;">grantleethememanager.cpp:127</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span style="color: #a0a000">directory</span> <span class="p">:</span> <span class="n">qAsConst</span><span class="p">(</span><span class="n">themesDirectories</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QDirIterator</span> <span class="n">dirIt</span><span class="p">(</span><span class="n">directory</span><span class="p">,</span> <span class="n">QStringList</span><span class="p">(),</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">AllDirs</span> <span style="color: #aa2211">|</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">NoDotAndDotDot</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/p/dfaure/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dfaure</a> you see this for loop l127 - l151, this will actually overwrites a found theme with a theme found in an other directory. So in the end the most general directory wins. IMO that is the opposite is expected, so that the general folders are fallback, if the local one is not found.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R77 PIM: Grantlee Theme</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17954">https://phabricator.kde.org/D17954</a></div></div><br /><div><strong>To: </strong>knauss, KDE PIM, mlaurent, dfaure<br /><strong>Cc: </strong>kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>