D18556: Fix tag name/type/gid missing in notifications about tags.

David Faure noreply at phabricator.kde.org
Mon Jan 28 08:18:30 GMT 2019


dfaure added a comment.


  Thanks for the quick review. I found more instances of "counter ==0" : AggregatedItemFetchScope::cacheOnly and AggregatedItemFetchScope::ignoreErrors. It seems clear to me that this needs the same treatment (patch ready), but I'm not sure how to unittest that. Maybe I'll just write a unittest for AggregatedItemFetchScope itself, unless you have a better idea of what might currently be broken by these bools being always true.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D18556

To: dfaure, ervin, dvratil
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190128/e94ab568/attachment.html>


More information about the kde-pim mailing list