D18672: Properly clean up scopes when deregistering a subscriber.

David Faure noreply at phabricator.kde.org
Sat Feb 2 17:12:38 GMT 2019


dfaure added inline comments.

INLINE COMMENTS

> dvratil wrote in notificationmanager.cpp:56
> Probably would be safer to move the`if` into `AkThread::quitThread()` and  make it a no-op if `startMode`  is `NoThread`.

Yeah, I thought about that. I didn't do it because it requires making `startMode` a member variable there, but indeed this seems like the cleanest solution, I'll do that.

REVISION DETAIL
  https://phabricator.kde.org/D18672

To: dfaure, dvratil
Cc: kde-pim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190202/3310af4b/attachment.html>


More information about the kde-pim mailing list