D18672: Properly clean up scopes when deregistering a subscriber.

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Looks good, just one small change regarding the thread/no-thread handling.

INLINE COMMENTS

> notificationmanager.cpp:56
>  {
> -    quitThread();
> +    if (thread() != QCoreApplication::instance()->thread()) // special case for the unittest
> +        quitThread();

Probably would be safer to move the`if` into `AkThread::quitThread()` and  make it a no-op if `startMode`  is `NoThread`.

REVISION DETAIL
  https://phabricator.kde.org/D18672

To: dfaure, dvratil
Cc: kde-pim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190202/8c3cc364/attachment.html>