D19357: PIM Text Edit: Fix compile with Qt 5.13 and QT_DISABLE_DEPRECATED_BEFORE=0x060000

Laurent Montel noreply at phabricator.kde.org
Wed Feb 27 07:08:13 GMT 2019


mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> textmessageindicator.cpp:189
>      painter.translate(0.5, 0.5);
> -    painter.drawRoundRect(1, 1, width() - 2, height() - 2, 1600 / width(), 1600 / height());
>  

it's wrong see:
void QPainter::drawRoundRect(const QRectF &r, int xRnd, int yRnd)
{

  drawRoundedRect(r, xRnd, yRnd, Qt::RelativeSize);

}

but

  void drawRoundedRect(const QRectF &rect, qreal xRadius, qreal yRadius,
                       Qt::SizeMode mode = Qt::AbsoluteSize);



> you use 2 differents sizemode

REPOSITORY
  R86 PIM: Text Editor

REVISION DETAIL
  https://phabricator.kde.org/D19357

To: marten, #kde_pim, dvratil, mlaurent
Cc: mlaurent, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190227/d45a52e6/attachment.html>


More information about the kde-pim mailing list