<table><tr><td style="">mlaurent requested changes to this revision.<br />mlaurent added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19357">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19357#inline-108132">View Inline</a><span style="color: #4b4d51; font-weight: bold;">textmessageindicator.cpp:189</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">painter</span><span class="p">.</span><span class="n">translate</span><span class="p">(</span><span style="color: #601200">0.5</span><span class="p">,</span> <span style="color: #601200">0.5</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">painter</span><span class="p">.</span><span class="n">drawRoundRect</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">,</span> <span style="color: #601200">1</span><span class="p">,</span> <span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span style="color: #601200">2</span><span class="p">,</span> <span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span style="color: #601200">2</span><span class="p">,</span> <span style="color: #601200">1600</span> <span style="color: #aa2211">/</span> <span class="n">width</span><span class="p">(),</span> <span style="color: #601200">1600</span> <span style="color: #aa2211">/</span> <span class="n">height</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">painter</span><span class="p">.</span><span class="n">drawRound<span class="bright">ed</span>Rect</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">,</span> <span style="color: #601200">1</span><span class="p">,</span> <span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span style="color: #601200">2</span><span class="p">,</span> <span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span style="color: #601200">2</span><span class="p">,</span> <span style="color: #601200">1600</span> <span style="color: #aa2211">/</span> <span class="n">width</span><span class="p">(),</span> <span style="color: #601200">1600</span> <span style="color: #aa2211">/</span> <span class="n">height</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">it's wrong see:<br />
void QPainter::drawRoundRect(const QRectF &r, int xRnd, int yRnd)<br />
{</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">drawRoundedRect(r, xRnd, yRnd, Qt::RelativeSize);</pre></div>

<p style="padding: 0; margin: 8px;">}</p>

<p style="padding: 0; margin: 8px;">but</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">void drawRoundedRect(const QRectF &rect, qreal xRadius, qreal yRadius,
                     Qt::SizeMode mode = Qt::AbsoluteSize);</pre></div>

<p style="padding: 0; margin: 8px;"></p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">you use 2 differents sizemode</p></blockquote></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R86 PIM: Text Editor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19357">https://phabricator.kde.org/D19357</a></div></div><br /><div><strong>To: </strong>marten, KDE PIM, dvratil, mlaurent<br /><strong>Cc: </strong>mlaurent, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss, dvratil<br /></div>