D19323: fix crash when mapping unified mailboxes to collections

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> unifiedmailboxmanager.cpp:391
>              }
> -
> -            mMailboxes.at(col.name())->setCollectionId(col.id());
> +            try { 
> +                mMailboxes.at(col.name())->setCollectionId(col.id());

We don't use exception in kde apps in general
why don't use

  std::unordered_map<....>::const_iterator got = mymap.find(col.name());
         if (got ==mMainBoxes.end()) {
              qWarning()...
          } else {
            .... setCollectionId(...)
          }

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D19323

To: jaham, dvratil, mlaurent
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190226/b5b996e2/attachment.html>