D19323: fix crash when mapping unified mailboxes to collections

Jan Hambrecht noreply at phabricator.kde.org
Tue Feb 26 19:59:13 GMT 2019


jaham added inline comments.

INLINE COMMENTS

> mlaurent wrote in unifiedmailboxmanager.cpp:391
> We don't use exception in kde apps in general
> why don't use
> 
>   std::unordered_map<....>::const_iterator got = mymap.find(col.name());
>          if (got ==mMainBoxes.end()) {
>               qWarning()...
>           } else {
>             .... setCollectionId(...)
>           }

Normally i would do that too. But there is a similar try-catch block in the function UnifiedMailboxManager::createDefaultBoxes. I just wanted to follow the coding style already used.

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D19323

To: jaham, dvratil, mlaurent
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190226/98524a9d/attachment.html>


More information about the kde-pim mailing list