D26119: Port QRegExp to QRegularExpression

Volker Krause noreply at phabricator.kde.org
Sun Dec 22 08:23:28 GMT 2019


vkrause added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in compat.cpp:57
> hmm, tbh I am not sure whether that would be beneficial or not; it depends on how many times createCompat() is called, looking at the code it's only called by ICalFormatImpl::populate(), but I don't know how many external users do call that function.

Right, it's probably not worth it in this case. I don't think this is a particularly hot path, and making it static has a cost too (non-sharable runtime memory).

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D26119

To: ahmadsamir, #kde_pim, winterz, vkrause
Cc: gjditchfield, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20191222/bcc119a0/attachment.html>


More information about the kde-pim mailing list