D26119: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> gjditchfield wrote in compat.cpp:57
> If I understand correctly, this creates a QRegularExpression, compiles the pattern, performs the match, then throws the object and compiled pattern away.  Should this declare a constant, so construction and pattern compilation only happen once?

hmm, tbh I am not sure whether that would be beneficial or not; it depends on how many times createCompat() is called, looking at the code it's only called by ICalFormatImpl::populate(), but I don't know how many external users do call that function.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D26119

To: ahmadsamir, #kde_pim, winterz, vkrause
Cc: gjditchfield, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20191222/759f2525/attachment-0001.html>