D20714: akonadi: fix some clazy warnings

Sergio Martins noreply at phabricator.kde.org
Sat Apr 27 17:52:30 BST 2019


smartins added inline comments.

INLINE COMMENTS

> dfaure wrote in itemcreatehandler.cpp:402
> @smartins Interesting. This means this is a clazy false positive. Did I miss a caveat somewhere explaining that the change should only be made if empty vs null makes no difference, unlike here?
> 
> I'll revert and add a silence-clazy comment.

Just QLatin1String("") even, I've checked with heaptrack and it doesn't allocate memory (unlike QString(""))

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D20714

To: dfaure, dvratil, vkrause
Cc: smartins, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190427/c6915a9e/attachment.html>


More information about the kde-pim mailing list