D20714: akonadi: fix some clazy warnings

[Sergio Martins]

smartins added inline comments.

INLINE COMMENTS

> dfaure wrote in itemcreatehandler.cpp:402
> @smartins Interesting. This means this is a clazy false positive. Did I miss a caveat somewhere explaining that the change should only be made if empty vs null makes no difference, unlike here?
> 
> I'll revert and add a silence-clazy comment.

README-empty-qstringliteral.md says:

"Note: Beware that `QString().isNull()` is `true` while both `QStringLiteral().isEmpty()` and `QStringLiteral("").isNull()` are `false`.
So be sure not to introduce subtle bugs when doing such replacements."

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D20714

To: dfaure, dvratil, vkrause
Cc: smartins, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190427/6c46e5f0/attachment.html>