D20789: FileFetchJob: unconditionally set `includeTeamDriveItems`, `includeItemsFromAllDrives`, `supportsTeamDrives`, `supportsAllDrives` query params

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  `supportsTeamDrives` documentation says "Use `supportsAllDrives` instead, for `includeTeamDriveItems` to use `includeItemsFromAllDrives`, so I think we don't have to set all four of them, only the "allDrives" versions, they all have the same effect. In this case 1:1 mapping with the REST API is not necessary, IMO

INLINE COMMENTS

> filefetchjob.h:137
> +
>      bool includeTeamDriveItems() const;
> +

Deprecate all the getters as well, please.

> filefetchjob.h:166
> +     */
> +    KGAPIDRIVE_DEPRECATED void setSupportsTeamDrives(bool supportsTeamDrives);
>  

Let's not introduce getters/setters that only alias other functions.

REPOSITORY
  R477 KGAPI Library

REVISION DETAIL
  https://phabricator.kde.org/D20789

To: barchiesi, dvratil
Cc: kde-pim, #libkgapi, barchiesi, gennad, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190428/01fa6c90/attachment.html>