D20362: Add test for CollectionScheduler, code cleanups, bugfixes.

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> collectionscheduler.cpp:325
>  
>      mScheduleLock.lock();
>      const uint timestamp = mSchedule.constBegin().key();

Could you please also fix this to use `QMutexLocker` and move it to the top of the method?

> collectionscheduler.cpp:329
>      mSchedule.remove(timestamp);
>      mScheduleLock.unlock();
>  

This is also broken, as below we are iterating over un-protected `collections` list...

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D20362

To: dfaure, dvratil
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190409/7efe6dc7/attachment.html>