D16323: Replace 10 year out of date ModelTest copy with QAIMTester

Volker Krause noreply at phabricator.kde.org
Mon Oct 22 12:04:54 BST 2018


vkrause added inline comments.

INLINE COMMENTS

> dvratil wrote in keylistmodel.cpp:40
> I think Kleopatra still depends on Qt 5.9 by default, so there should probably be a  QT_VERSION check here (and maybe remove the KLEO_MODEL_TEST check?)

I don't think we want to enable this unconditionally, too expensive at runtime? I didn't add a version check as this is apparently a developer-only thing that needs code changes anyway to be activated (there is no place defining KLEO_MODEL_TEST), so you'd not want this to silently skip things when explicitly activating it on an older Qt version I guess.

REPOSITORY
  R90 PIM: Kleo Library

REVISION DETAIL
  https://phabricator.kde.org/D16323

To: vkrause, aheinecke
Cc: dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181022/60a1e039/attachment.html>


More information about the kde-pim mailing list