D16323: Replace 10 year out of date ModelTest copy with QAIMTester

Daniel Vrátil noreply at phabricator.kde.org
Mon Oct 22 20:59:20 BST 2018


dvratil added inline comments.

INLINE COMMENTS

> vkrause wrote in keylistmodel.cpp:40
> I don't think we want to enable this unconditionally, too expensive at runtime? I didn't add a version check as this is apparently a developer-only thing that needs code changes anyway to be activated (there is no place defining KLEO_MODEL_TEST), so you'd not want this to silently skip things when explicitly activating it on an older Qt version I guess.

Uh, I haven't realized this is an actual application code, not a unittest. Ignore me, please :)

REPOSITORY
  R90 PIM: Kleo Library

REVISION DETAIL
  https://phabricator.kde.org/D16323

To: vkrause, aheinecke
Cc: dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181022/aec66467/attachment.html>


More information about the kde-pim mailing list