D16508: Eventviews: properly fall back to color-generator if ColorAttribute is absent

[David Faure]

dfaure created this revision.
dfaure added reviewers: ochurlaud, dkurz, dvratil.
dfaure requested review of this revision.

REVISION SUMMARY
  This was introduced by 1ec2e08 <https://phabricator.kde.org/R76:1ec2e08a83c074ebf4dad554c32495e0bf6eb8ed> which only called the color-generator
  code when there *is* a ColorAttribute on the collection (with an
  invalid color, which seems unlikely), rather than when the attribute
  isn't there.
  
  I thought this was the bug that made all new resources red (with caldav)
  but actually that seems to come from the resource itself. So now I'm not
  100% sure about this commit anymore, although it still seems to make
  sense to me -- for other resources, possibly.

TEST PLAN
  Disabling the code that reads from the ColorAttribute
  and removing all "Resources Colors" entries from ~/.config/eventviewsrc,
  the colors are properly generated.

BRANCH
  2018_10_color_generation (branched from Applications/18.08)

REVISION DETAIL
  https://phabricator.kde.org/D16508

AFFECTED FILES
  src/helper.cpp

To: dfaure, ochurlaud, dkurz, dvratil
Cc: #kde_pim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181029/671168a6/attachment.html>