D16508: Eventviews: properly fall back to color-generator if ColorAttribute is absent

Denis Kurz noreply at phabricator.kde.org
Wed Oct 31 11:37:18 GMT 2018


dkurz added a comment.


  In D16508#351114 <https://phabricator.kde.org/D16508#351114>, @ochurlaud wrote:
  
  > If it is just factoring, you can ship it. If not, I'd like to be sure not to miss anything in the change.
  
  
  The old code returns an invalid color if the preference color is invalid and the collection doesn't have a color attribute (as the big if is never entered).
  
  The new code generates a new color in this case.

BRANCH
  2018_10_color_generation (branched from Applications/18.08)

REVISION DETAIL
  https://phabricator.kde.org/D16508

To: dfaure, ochurlaud, dkurz, dvratil
Cc: #kde_pim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181031/23d47f50/attachment.html>


More information about the kde-pim mailing list