D16242: korgac: Add an option to not grab keyboard focus when a reminder is displayed

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> alarmdockwindow.cpp:47
>      const bool autostart = config.readEntry("Autostart", true);
> +    bool grabfocus = config.readEntry("GrabFocus", false);
>      const bool alarmsEnabled = config.readEntry("Enabled", true);

`const`, `grabFocus`

> alarmdockwindow.cpp:96
>  
> +    mGrabFocus =
> +        contextMenu()->addAction(i18nc( "@action:inmenu", "Reminder grabs focus"));

Maybe add a tooltip with explanation what this really means - "Reminder grabs focus" is quite technical

> alarmdockwindow.cpp:98
> +        contextMenu()->addAction(i18nc( "@action:inmenu", "Reminder grabs focus"));
> +    connect(mGrabFocus, SIGNAL(toggled(bool)), SLOT(toggleGrabFocus(bool)));
> +    mGrabFocus->setCheckable(true);

Use the new connect method (via method pointers)

> alarmdockwindow.cpp:151
> +{
> +    qCDebug(KOALARMCLIENT_LOG);
> +    KConfigGroup config(KSharedConfig::openConfig(), "General");

Remove this.

Or add some more context - in release builds the method name is not known, so this just prints "<uknown>" to the log

> alarmdockwindow.cpp:154
> +    config.writeEntry("GrabFocus", checked);
> +    config.sync();
> +}

No need to explicitly sync

REPOSITORY
  R210 KOrganizer

REVISION DETAIL
  https://phabricator.kde.org/D16242

To: dfries, mlaurent, dvratil
Cc: dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181019/fc959ae6/attachment.html>