D16242: korgac: Add an option to not grab keyboard focus when a reminder is displayed

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Let's just improve the wording a little, rest of the code looks OK now.
  
  Oh and rename the `grabfocus` variable to `grabFocus`, please.

INLINE COMMENTS

> dfries wrote in alarmdockwindow.cpp:96
> How does this sound?
> menu item: "Reminder Requests Focus"
> 
> tooltip: "Enable when you want the reminder dialog to request keyboard focus when a notification appears."
> or
> "Enable for the reminder dialog to request keyboard focus when a notification appears."
> or
> "Enable to automatically get keyboard focus when a notification appears."
> 
> menus disable tooltips by default, adding:
> contextMenu()->setToolTipsVisible(true);
> 
> I'd be glad to redo this patch to not include the menu option and not grab focus.  That would simplify things.  I just figured as something went out of their way to add activateWindow, that wouldn't to over, so I made it optional.
> 
> https://blog.codinghorror.com/please-dont-steal-my-focus/

Usually, the wording of tooltips is what happens when you use/enable it, rather than "use/enable it to achieve something", so  "When this option is enabled the reminder dialog will automatically receive keyboard focus when it opens." is better IMHO.

I haven't realized this is a menu action, not a checkbox somewhere in a settings dialog, but I think the tooltip does make sense in this case and is OK.

Having this as an option is perfectly OK. We like having options :-)

REPOSITORY
  R210 KOrganizer

REVISION DETAIL
  https://phabricator.kde.org/D16242

To: dfries, mlaurent, dvratil
Cc: dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181021/82e63b79/attachment.html>