D16245: korgac: Save size and position on dialog hide/close and improve restore

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added inline comments.

INLINE COMMENTS

> alarmdialog.cpp:147
>      KConfigGroup generalConfig(config, "General");
> -    QPoint pos = generalConfig.readEntry("Position", QPoint(0, 0));
> +    mRect = generalConfig.readEntry("Position", QRect());
> +    if (!mRect.isNull()) {

This is not compatible with the previous settings (because it was a `QPoint`) - you should probably continue reading Position as `QPoint` and add a new config entry instead called "Size" to read as `QSize`. You can then construct a `QRect` from `QPoint` and `QSize`. Remember to adjust saving the same way.

REPOSITORY
  R210 KOrganizer

REVISION DETAIL
  https://phabricator.kde.org/D16245

To: dfries, mlaurent, dvratil
Cc: dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181016/f00cfcf8/attachment.html>